Pipes-Mariana-Hotel #26

lmarianarp19 · 2017-09-11T07:26:55Z

Hotel

Congratulations! You're submitting your assignment!

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I decided to create at Admin class to control the reservations for individual rooms and blocks, I need this because I need something to control the reservations. At the beginning I thought was easier creating class variables instead.
Describe a concept that you gained more clarity on as you worked on this assignment.	How to work in a class with methods from a different class.
Describe a nominal test that you wrote for this assignment.	To see if it is possible to make a reservation when I know there is extra rooms.
Describe an edge case test that you wrote for this assignment.	To expect an error if there is not rooms available for an specific date range.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	It took me a lot of effort because sometimes I was no sure how to start writing the pseudocode. Doing first the test was also difficult because I was no sure about the names to use.

PilgrimMemoirs · 2017-09-25T19:16:36Z

Feature	Feedback
Baseline
Used git regularly	Need to commit more often
Answer comprehension questions	Well Done
Design
Each class is responsible for a single piece of the program	Well Done
Classes are loosely coupled	Well Done - nice use of splitting up functionality into many mehthods
Wave 1
List rooms	Well Done
Reserve a room for a given date range	Well Done
List reservations for a given date	Well Done
Calculate reservation price	Well Done - method name `totalcost` should have an underscore between the two words in the name, `total_cost`.
Invalid date range produces an error	Well Done
Test coverage	Well Done
Wave 2
View available rooms for a given date range	Well Done
Reserving a room that is not available produces an error	Well Done
Test coverage	Well Done
Wave 3
Create a block of rooms	Well Done
Check if a block has rooms	Well Done
Reserve a room from a block	Well Done
Test coverage	Well Done
Additional Feedback
Nice work splitting functionality between methods and using them to call each other.
Well organized tests, appropriate use of `before do` in each respected `describe` block.
Submission meets projects expectations, nice work.

lmarianarp19 added 12 commits September 7, 2017 10:04

Commit of the first wave without list of reservations per day

4468984

Wave 1 finish

a6583a8

overlap? method in DateRange class

b264077

Add room number to reservation parameters

1996c66

Creates hash of rooms

fd80b35

Second wave

ae44024

Add argument error if there is no rooms avaliables

11d44cb

initialize block

7e8edb4

Block class with total cost ans reserve

5f10e08

Rooms avaliables in block

fe8a850

Look if it is possible to create a block

e43e8c3

create block

490632d

lmarianarp19 added 4 commits October 1, 2017 14:39

Add design activity

be3ff6a

Try to create class room

57fb733

Revisiting Hotel

76f6ea3

Revisiting Hotel

b3f4648